Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nexus): coin type should be ICS20 if the coin is from external cosmos chain #2194

Merged
merged 2 commits into from
Oct 14, 2024

improve comments

da162d5
Select commit
Loading
Failed to load commit list.
Merged

fix(nexus): coin type should be ICS20 if the coin is from external cosmos chain #2194

improve comments
da162d5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 14, 2024 in 0s

39.21% (+0.00%) compared to 57ecd83

View this Pull Request on Codecov

39.21% (+0.00%) compared to 57ecd83

Details

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.21%. Comparing base (57ecd83) to head (da162d5).

Files with missing lines Patch % Lines
x/nexus/keeper/lockable_asset.go 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2194   +/-   ##
=======================================
  Coverage   39.20%   39.21%           
=======================================
  Files         373      373           
  Lines       31726    31731    +5     
=======================================
+ Hits        12439    12444    +5     
- Misses      18346    18347    +1     
+ Partials      941      940    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.