Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nexus)!: allow wasm contracts to query for tx hash and index #2178

Merged
merged 6 commits into from
Sep 10, 2024
Merged

feat(nexus)!: allow wasm contracts to query for tx hash and index #2178

merged 6 commits into from
Sep 10, 2024

Conversation

fish-sammy
Copy link
Contributor

@fish-sammy fish-sammy commented Sep 4, 2024 •
edited
Loading

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@fish-sammy fish-sammy requested a review from a team as a code owner September 4, 2024 02:09
@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 47.61905% with 33 lines in your changes missing coverage. Please review.

Project coverage is 49.59%. Comparing base (1848c6b) to head (1c5f7e2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/nexus/keeper/wasmer_engine.go 0.00% 19 Missing ⚠️
x/nexus/keeper/wasm_querier.go 0.00% 10 Missing ⚠️
x/nexus/keeper/msg_id_generator.go 50.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2178      +/-   ##
==========================================
+ Coverage   49.52%   49.59%   +0.06%     
==========================================
  Files         269      272       +3     
  Lines       16100    16151      +51     
==========================================
+ Hits         7974     8010      +36     
- Misses       7514     7529      +15     
  Partials      612      612

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fish-sammy fish-sammy force-pushed the AXE-4368-Allow-wasm-contracts-to-retrieve-the-Axelar-tx-hash branch from 5f0812c to 2df1f54 Compare September 4, 2024 16:53
cgorenflo
cgorenflo reviewed Sep 4, 2024
View reviewed changes
x/nexus/exported/types.go Outdated Show resolved Hide resolved
x/nexus/keeper/tx_id_generator.go Outdated Show resolved Hide resolved
x/nexus/keeper/wasm_querier.go Outdated Show resolved Hide resolved
x/nexus/keeper/wasmer_engine.go Show resolved Hide resolved
cjcobb23
cjcobb23 requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@cjcobb23 cjcobb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes because I don't think we should hash the transaction on every wasm call. Seems like uneccessary performance overhead.

x/nexus/exported/types.go Outdated Show resolved Hide resolved
x/nexus/exported/types.go Outdated Show resolved Hide resolved
x/nexus/keeper/wasmer_engine.go Outdated Show resolved Hide resolved
x/nexus/keeper/tx_id_generator.go Outdated Show resolved Hide resolved
x/nexus/keeper/tx_id_generator.go Outdated Show resolved Hide resolved
x/nexus/keeper/tx_id_generator.go Outdated Show resolved Hide resolved
@fish-sammy fish-sammy merged commit 7587fcd into main Sep 10, 2024
7 of 9 checks passed
@fish-sammy fish-sammy deleted the AXE-4368-Allow-wasm-contracts-to-retrieve-the-Axelar-tx-hash branch September 10, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcobb23 cjcobb23 cjcobb23 approved these changes

@cgorenflo cgorenflo cgorenflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fish-sammy @cgorenflo @cjcobb23