refactor: removed unutilized and deprecated properties in AxelarApp #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following properties were removed from the AxelarApp struct due to them either being unused, or deprecated: 'legacyAmino', 'invCheckPeriod', 'ibcKeeper', 'evidenceKeeper', 'feegrantKeeper', 'tkeys', 'memKeys' and 'configurator'. Also, each keeper is now defined closer to its corresponding usage throughout the app.go file. Consequently, logger parameter is removed from the NewAppModule in module.go file as it is unused. Simplification aims for better readability and maintenance of the codebase.
cgorenflo
requested review from
jcs47,
haiyizxx,
milapsheth and
cjcobb23
as code owners
haiyizxx
approved these changes
Oct 25, 2023
fish-sammy
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following properties were removed from the AxelarApp struct due to them either being unused, or deprecated: 'legacyAmino', 'invCheckPeriod', 'ibcKeeper', 'evidenceKeeper', 'feegrantKeeper', 'tkeys', 'memKeys' and 'configurator'. Also, each keeper is now defined closer to its corresponding usage throughout the app.go file. Consequently, logger parameter is removed from the NewAppModule in module.go file as it is unused. Simplification aims for better readability and maintenance of the codebase.