Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #64 - added fallback for VS22 17.11+ in GetPointer #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vojtechmusilek
Copy link

Added fallback to non generic pointer which seems to work after the changes in 17.11+.
This fixes issue #64 .

Tested on:

  • VS22 - 17.10 (17.10.5)
  • VS22 - 17.13 (17.13.0)

Tested with:

  • C#
    • var genericList = new List()
    • var points = new List<System.Drawing.PointF>()
    • var array = new double[100]
    • var linkedList = new LinkedList()
    • IList
    • ICollection
    • IEnumerable
  • C++
    • int c_array[100]
    • std::vector stl_vector(100)
    • std::array<int, 100>
    • std::deque stl_deque
    • std::list stl_list
    • std::set stl_set
    • boost::array<int, 100> boost_array
    • boost::circular_buffer boost_circular_buffer(100)
    • boost::container::vector boost_vector(100)
    • boost::container::static_vector<int, 100> boost_static_vector

@vojtechmusilek
Copy link
Author

After further investigation, it seems like when I remove the 'genericPtrExpr' and keep only the fallback code, everything still works. But I'm not sure if that wouldn't break something else.

@awulkiew
Copy link
Owner

Thanks for the PR. I haven't looked into this issue yet due to the lack of free time. It seems to be wierd that C# is affected by pointers but maybe I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants