Fix for non-planar lumped ports #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughcars
force-pushed
the
hughcars/lumped-port-fix
branch
4 times, most recently
from
0a797ee
to
b8df173
Compare
…ch to more robust detection of out of plane
…edded in three dimensions - Additionally introduce GetDirectionalExtent which computes the maximum separation between points within a geometric object, aligned with a given direction.
hughcars
force-pushed
the
hughcars/lumped-port-fix
branch
from
b8df173
to
8006ee8
Compare
sebastiangrimberg
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where non-planar lumped ports were being errored out incorrectly. The fix involves fixing the bounding box calculation to better handle non-planar two dimensional objects embedded in three dimensional space, and only performing the quadrilateral area check against the integrated area if a planar port is discovered. An extra "GetProjectedLength" helper function is also included, at present it is only used in a debug assertion.
Issue #, if available:
#89