-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial assembly support using libCEED #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiangrimberg
force-pushed
the
sjg/driven-port-debug
branch
from
July 17, 2023 18:34
cc43db8
to
81190bc
Compare
sebastiangrimberg
force-pushed
the
sjg/libceed-pa-dev
branch
3 times, most recently
from
July 17, 2023 19:10
dce706a
to
148d51e
Compare
sebastiangrimberg
force-pushed
the
sjg/driven-port-debug
branch
from
August 7, 2023 21:28
c6fcae6
to
7aa10db
Compare
sebastiangrimberg
force-pushed
the
sjg/libceed-pa-dev
branch
2 times, most recently
from
August 7, 2023 21:59
46d0296
to
a19580b
Compare
3 tasks
sebastiangrimberg
force-pushed
the
sjg/libceed-pa-dev
branch
from
August 8, 2023 01:11
a19580b
to
cee07e5
Compare
hughcars
reviewed
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only non-trivial is the user experience about specifying p/h multigrid and the terminology for the two.
sebastiangrimberg
force-pushed
the
sjg/driven-port-debug
branch
from
August 8, 2023 18:16
9a51e9f
to
393b428
Compare
sebastiangrimberg
force-pushed
the
sjg/libceed-pa-dev
branch
3 times, most recently
from
August 15, 2023 02:07
6296e21
to
1155bd7
Compare
…ce" configuration file options
…er assembly of multigrid hierarchy, partial assembly for auxiliary operators and solvers (postprocessing, div-free solver, etc.)
…hreshold below which operators are fully assembled Also adds option for libCEED multigrid transfer operators.
…level operators for multigrid
…rmSolver -> EnergyNormSolver
sebastiangrimberg
force-pushed
the
sjg/libceed-pa-dev
branch
from
August 22, 2023 15:17
1155bd7
to
8f6c834
Compare
hughcars
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for operator partial assembly for meshes containing either tensor-product elements or simplex elements using the libCEED library. This makes use of some recent improvements adding support for H(div) and H(curl) elements in libCEED, see CEED/libCEED#1265 and CEED/libCEED#1156.
This resolves the first part of #3. As the libCEED H(curl) and H(div) support does not yet include GPU-backends, the rest of #3 remains in progress and will come at a later date. For now, PA is disabled by default and must be enabled by the user with the
"PartialAssemblyOrder"
and"Device"
configuration file keywords. In the future we will come up with easier default options to make use of PA.This PR is a follow-up to the changes in for #47. Since this PR contains some follow-up changes to changes also made in this PR, I propose we review both simultaneously and only merge #47 quickly followed by #64 once comments with both have been addressed and they are both approved.
TODO