Address PR feedback

awslabs · Mar 12, 2024 · a791245 · a791245
1 parent a59241d
commit a791245
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/palace/fem/integ/mixedvecgrad.cpp b/palace/fem/integ/mixedvecgrad.cpp
@@ -5,10 +5,16 @@
 
 #include "fem/libceed/coefficient.hpp"
 #include "fem/libceed/integrator.hpp"
+#include "utils/diagnostic.hpp"
+
+PalacePragmaDiagnosticPush
+PalacePragmaDiagnosticDisableUnused
 
 #include "fem/qfunctions/hcurl_qf.h"
 #include "fem/qfunctions/hcurlhdiv_qf.h"
 
+PalacePragmaDiagnosticPop
+
 namespace palace
 {
 

diff --git a/palace/fem/integrator.hpp b/palace/fem/integrator.hpp
@@ -13,8 +13,8 @@ namespace palace
 class MaterialPropertyCoefficient;
 
 //
-// Classes which implement or extend bilinear and linear form integrators.
-// In doc strings u refers to the trial function, and v the test function.
+// Classes which implement or extend bilinear and linear form integrators. In doc strings u
+// refers to the trial function, and v the test function.
 //
 
 namespace fem
@@ -188,6 +188,7 @@ class DivDivMassIntegrator : public BilinearFormIntegrator
 // Integrator for a(u, v) = (Q grad u, v) for u in H1 and v in H(curl) or H(div).
 class MixedVectorGradientIntegrator : public BilinearFormIntegrator
 {
+protected:
   int trial_map_type = mfem::FiniteElement::UNKNOWN_MAP_TYPE;
   int test_map_type = mfem::FiniteElement::UNKNOWN_MAP_TYPE;
 

diff --git a/test/unit/test-libceed.cpp b/test/unit/test-libceed.cpp
@@ -895,7 +895,7 @@ void RunCeedIntegratorTests(MPI_Comm comm, const std::string &input, int ref_lev
     {
       BilinearForm a_test(h1_fespace, rt_fespace);
       mfem::MixedBilinearForm a_ref(&h1_fespace.Get(), &rt_fespace.Get());
-      if ((dim == 3 && !bdr_integ) || (dim == 2 && !bdr_integ))  // Only in 2D or 3D
+      if (!bdr_integ)
       {
         switch (coeff_type)
         {