Fix uninitialized ball.planar value

awslabs · Aug 10, 2023 · 51a930d · 51a930d
1 parent 1f611a9
commit 51a930d
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/palace/utils/geodata.cpp b/palace/utils/geodata.cpp
@@ -792,13 +792,14 @@ BoundingBall BoundingBallFromPointCloud(MPI_Comm comm,
         });
 
     constexpr double planar_tolerance = 1e-9;
-    if (PerpendicularDistance({delta, n_radial}, out_of_plane) > planar_tolerance)
+
+    ball.planar = PerpendicularDistance({delta, n_radial}, out_of_plane) < planar_tolerance;
+    if (!ball.planar)
     {
       // The points are not functionally coplanar, zero out the normal.
       Vector3dMap(ball.planar_normal.data()) *= 0;
       MFEM_VERIFY(PerpendicularDistance({delta, n_radial}, out_of_plane) <= ball.radius,
                   "A point perpendicular must be contained in the ball");
-      ball.planar = true;
     }
   }