Some CMake policy updates

awslabs · May 30, 2024 · 3edd16c · 3edd16c
1 parent 20c3719
commit 3edd16c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -50,6 +50,8 @@ if(PALACE_WITH_CUDA AND PALACE_WITH_HIP)
   message(FATAL_ERROR "PALACE_WITH_CUDA is not compatible with PALACE_WITH_HIP")
 endif()
 if(PALACE_WITH_CUDA)
+  # Note: The new behavior of CMake policy CMP0104 will initialize CMAKE_CUDA_ARCHITECTURES
+  # to an (old) compatible value even when not set by the user.
   enable_language(CUDA)
   get_filename_component(NVCC_DIR ${CMAKE_CUDA_COMPILER} DIRECTORY)
   get_filename_component(BIN_NVCC_DIR ${NVCC_DIR} DIRECTORY)

diff --git a/cmake/ExternalPalace.cmake b/cmake/ExternalPalace.cmake
@@ -80,9 +80,6 @@ string(REPLACE ";" "; " PALACE_OPTIONS_PRINT "${PALACE_OPTIONS}")
 message(STATUS "PALACE_OPTIONS: ${PALACE_OPTIONS_PRINT}")
 
 include(ExternalProject)
-if(POLICY CMP0114)
-  cmake_policy(SET CMP0114 NEW)
-endif()
 ExternalProject_Add(palace
   DEPENDS           ${PALACE_DEPENDENCIES}
   SOURCE_DIR        ${CMAKE_SOURCE_DIR}/palace