Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling data cache isn't mentioned in the documentation #752

Closed
mhnap opened this issue Feb 14, 2024 · 3 comments
Closed

Disabling data cache isn't mentioned in the documentation #752

mhnap opened this issue Feb 14, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@mhnap
Copy link

mhnap commented Feb 14, 2024

#616 introduced disabling of data cache by setting --max-cache-size=0, but this behavior is not mentioned in the Caching configuration section of the documentation. Would be great to include this information also there and maybe even add more details (is metadata cache stored in the same --cache dir, is metadata cache size can be configured, or it's limited to some value, etc).

@dannycjones dannycjones added the documentation Improvements or additions to documentation label Feb 15, 2024
@jamesbornholt
Copy link
Member

This is intentionally undocumented right now, I think, as we weren't sure how useful metadata caching would be on its own. If you have a use case for it we'd be super interested to hear more!

@mhnap
Copy link
Author

mhnap commented Feb 21, 2024

Aha, got it. My goal was to perform benchmarks with enabled cache for different --max-cache-size and --metadata-ttl values, and observe how they affect Get/List/Head request numbers and total test time. To isolate and understand better test results, I used to set --max-cache-size or --metadata-ttl to zero. However, I don't have any use case for metadata caching on its own other than benchmarks for now. Still, I think it would be great to see more details in the documentation if possible.

@passaro
Copy link
Contributor

passaro commented May 2, 2024

Hi @mhnap. We just merged #855, which enables (and documents) metadata-only caching. Closing #752 and #768.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants