-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 44 config via url #53
base: v2-alpha
Are you sure you want to change the base?
Feature/issue 44 config via url #53
Conversation
My attempt at skipping the modal (not working):
It seems that functions can be called this way, but the argument to call() seems to be ignored and the retrn value for getSettings is similarly undefined. |
Open question: to what extent does the browser interfere with prefilling the fields in case the user has used the page before and the browser might try to replace form field values? |
@john-aws Any feedback regarding the bullet points I mentioned or the PR in general? |
@ninovanhooff Apologies for the delay and thanks for your work here. I will try to find time this week to look at the changes. |
hi @john-aws , is this PR still in progress ? |
Issue: 44
Description of changes: Whenever settings change the url is updated with a base64 encoded version of the entire settings object. The url can be shared and bookmarked. When loading the settings controller, the url is checked for the
settings
query param and it is decoded when found. This pre-populates the settings modalAreas for improvement
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.