-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: RDK v1.0 refactor #426
Conversation
…b/aws-config-rdk into rdk-on-rdk-sirromb
Does this PR add any capability to fine tune the lambda functions? For example in my use case we want to be able to use AWS Lambda Powertools and this means I need to be able to set TracingConfig and Environment variables. I do not see any documented way I can achieve this. I currently copy the deployed CF template and update it to include these properties as follows: "Ec2TestRuleLambdaFunction": {
"Type": "AWS::Lambda::Function",
"Properties": {
"FunctionName": "RDK-Rule-Function-Ec2TestRule",
"Code": {
"S3Bucket": {
"Ref": "SourceBucket"
},
"S3Key": "Ec2TestRule/Ec2TestRule.zip"
},
"Description": "Function for AWS Config Rule Ec2TestRule",
"Environment": {
"Variables": {
"POWERTOOLS_SERVICE_NAME": "config-rdk-rules",
"LOG_LEVEL": "Debug",
"POWERTOOLS_LOGGER_SAMPLE_RATE": "1",
"POWERTOOLS_LOGGER_LOG_EVENT": "true",
"POWERTOOLS_METRICS_NAMESPACE": "rdk_config"
}
},
"TracingConfig": {
"Mode": "Active"
},
"Handler": "Ec2TestRule.lambda_handler",
"MemorySize": "256",
"Role": "arn:aws:iam::123456789012:role/ConfigRulesCentralizedLambdaRole",
"Runtime": "python3.9",
"Timeout": "60",
"Tags": []
}
},
It would be great if a CDK based version of RDK will allow such customization as required. Interestingly the powertools repo has an open PR to add typing support for config rules |
@austindimmer - Currently, that's not scoped into this PR, but it's something we're looking to add, and the RDK 1.0 refactor should make it easier to add features like this. Existing Issue for observability, feel free to add any specific things you'd be looking from this: #376 |
Thanks for the insight it is great to hear that these features are already on the roadmap. |
Closing this one -- CDK support was the core piece here but makes it significantly harder to maintain and not worth the refactor effort. Other pieces of this project will still be performed incrementally. |
This is a draft of an RDK v1.0 refactor that adds CDK support, breaks up the monolithic rdk.py, adds Python package best practices, and adds support for CFN Guard rules.