Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom policy rule #357

Closed
wants to merge 7 commits into from
Closed

Conversation

liuyangc3
Copy link

*Issue #356

Description of changes:
Support create and deploy custom policy rule

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bmorrissirromb
Copy link
Collaborator

Closing this; the implementation is not aligned with the "RDK way" of creating rules. Specifically, this implementation would make CFNGuard rules a special case where rdk.py creates the rule directly using put_config_rule. RDK rules should, instead, use the pattern of deploying rules via a CloudFormation template generated by rdk.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants