Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.11.0 Release #2018

Merged
merged 22 commits into from
Oct 4, 2024
Merged

v1.11.0 Release #2018

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
1eaede8
Release 1.10.0 (#1910)
disa6302 Mar 12, 2024
f107343
Viewer fix (#1953)
disa6302 Mar 20, 2024
4f1d3ad
Release 1.10.2 (#1981)
niyatim23 May 9, 2024
b54d180
addIceServerConfig revert
disa6302 Jun 24, 2024
c93c47c
CI
disa6302 Jun 24, 2024
323d91d
UT fixes, unused var
disa6302 Jun 24, 2024
936f5ec
one more unused
disa6302 Jun 24, 2024
b2162c6
version update
disa6302 Jun 25, 2024
4cd8eed
port static build fix prodc
hassanctech Aug 12, 2024
6bc0d2d
build fixes, remove call to timer queue kick
hassanctech Aug 27, 2024
4b5ed47
update mbedtls to latest LTS in 2.28 track
hassanctech Aug 28, 2024
e40fab5
Update libwebsockets-CMakeLists.txt
hassanctech Aug 29, 2024
ad2922a
fix mac build mbedtls, add option for ca cert
hassanctech Aug 30, 2024
38e942c
need to add definition so it can be used downstream even if it was sp…
hassanctech Aug 30, 2024
3652e86
Default ENABLE_KVS_THREADPOOL to OFF
stefankiesz Sep 17, 2024
df7f38b
Update README.md to reflect threadpool changes
stefankiesz Sep 17, 2024
096cafe
Add cmake flag for iot creds (#2056)
sirknightj Sep 18, 2024
e22e08b
Prepare for 1.11.0 release.
stefankiesz Sep 26, 2024
d9ab52d
Add instructions for using IoT credentials in the samples and documen…
sirknightj Oct 2, 2024
d5d09c8
Change branch target from master to main (#2059)
sirknightj Oct 3, 2024
77e2c47
Merge branch 'main' into 1.10.3
hassanctech Oct 3, 2024
86aed1d
Update libkvsCommonLws-CMakeLists.txt to new release
stefankiesz Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
run: |
bash scripts/check-clang.sh
mac-os-build-clang:
runs-on: macos-11
runs-on: macos-12
env:
CC: /usr/bin/clang
CXX: /usr/bin/clang++
Expand All @@ -50,7 +50,7 @@ jobs:
cd build
./tst/webrtc_client_test
mac-os-build-gcc:
runs-on: macos-11
runs-on: macos-12
env:
CC: gcc
CXX: g++
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
cd build
./tst/webrtc_client_test
static-build-mac:
runs-on: macos-11
runs-on: macos-12
env:
AWS_KVS_LOG_LEVEL: 2
permissions:
Expand Down
2 changes: 1 addition & 1 deletion samples/Common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ STATUS initializePeerConnection(PSampleConfiguration pSampleConfiguration, PRtcP
}

CHK_STATUS(createPeerConnection(&configuration, ppRtcPeerConnection));
CleanUp:
CleanUp:

CHK_LOG_ERR(retStatus);

Expand Down
1 change: 0 additions & 1 deletion src/source/Ice/IceAgent.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1861,7 +1861,6 @@ STATUS iceAgentInitRelayCandidate(PIceAgent pIceAgent, UINT32 iceServerIndex, KV
callback.relayAddressAvailableFn = NULL;
callback.turnStateFailedFn = turnStateFailedFn;


CHK_STATUS(createTurnConnection(&pIceAgent->iceServers[iceServerIndex], pIceAgent->timerQueueHandle,
TURN_CONNECTION_DATA_TRANSFER_MODE_SEND_INDIDATION, protocol, &callback, pNewCandidate->pSocketConnection,
pIceAgent->pConnectionListener, &pTurnConnection));
Expand Down
9 changes: 9 additions & 0 deletions src/source/PeerConnection/Rtcp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,15 @@ static STATUS onRtcpReceiverReport(PRtcpPacket pRtcpPacket, PKvsPeerConnection p
UINT32 rttPropDelayMsec = 0, rttPropDelay, delaySinceLastSR, lastSR, interarrivalJitter, extHiSeqNumReceived, cumulativeLost, senderSSRC, ssrc1;
UINT64 currentTimeNTP = convertTimestampToNTP(GETTIME());

UNUSED_PARAM(rttPropDelayMsec);
UNUSED_PARAM(rttPropDelay);
UNUSED_PARAM(delaySinceLastSR);
UNUSED_PARAM(lastSR);
UNUSED_PARAM(interarrivalJitter);
UNUSED_PARAM(extHiSeqNumReceived);
UNUSED_PARAM(cumulativeLost);
UNUSED_PARAM(senderSSRC);

CHK(pKvsPeerConnection != NULL && pRtcpPacket != NULL, STATUS_NULL_ARG);
// https://tools.ietf.org/html/rfc3550#section-6.4.2
if (pRtcpPacket->payloadLength != RTCP_PACKET_RECEIVER_REPORT_MINLEN) {
Expand Down
4 changes: 3 additions & 1 deletion src/source/Sctp/Sctp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,8 @@ INT32 onSctpInboundPacket(struct socket* sock, union sctp_sockstore addr, PVOID
if (data != NULL) {
free(data);
}

if (STATUS_FAILED(retStatus)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a log check error here please?

return -1;
}
return 1;
}
4 changes: 4 additions & 0 deletions src/source/Signaling/LwsApiCalls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ INT32 lwsHttpCallbackRoutine(struct lws* wsi, enum lws_callback_reasons reason,
PStateMachineState pStateMachineState;
BOOL skewMapContains = FALSE;

UNUSED_PARAM(logLevel);
DLOGV("HTTPS callback with reason %d", reason);

// Early check before accessing the custom data field to see if we are interested in processing the message
Expand Down Expand Up @@ -1493,6 +1494,9 @@ STATUS joinStorageSessionLws(PSignalingClient pSignalingClient, UINT64 time)
PCHAR pResponseStr;
UINT32 resultLen;

UNUSED_PARAM(pResponseStr);
UNUSED_PARAM(pLwsCallInfo);
UNUSED_PARAM(resultLen);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem like something we should log. Why else are we having these variables be stored locally?

CHK(pSignalingClient != NULL, STATUS_NULL_ARG);
CHK(pSignalingClient->channelEndpointWebrtc[0] != '\0', STATUS_INTERNAL_ERROR);

Expand Down
2 changes: 1 addition & 1 deletion src/source/Signaling/StateMachine.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ StateMachineState SIGNALING_STATE_MACHINE_STATES[] = {
fromGetIceConfigSignalingState, executeGetIceConfigSignalingState, defaultSignalingStateTransitionHook, SIGNALING_STATES_DEFAULT_RETRY_COUNT,
STATUS_SIGNALING_GET_ICE_CONFIG_CALL_FAILED},
{SIGNALING_STATE_READY, SIGNALING_STATE_GET_ICE_CONFIG | SIGNALING_STATE_DISCONNECTED | SIGNALING_STATE_READY, fromReadySignalingState,
executeReadySignalingState, defaultSignalingStateTransitionHook, INFINITE_RETRY_COUNT_SENTINEL, STATUS_SIGNALING_READY_CALLBACK_FAILED},
executeReadySignalingState, defaultSignalingStateTransitionHook, INFINITE_RETRY_COUNT_SENTINEL, STATUS_SIGNALING_READY_CALLBACK_FAILED},
{SIGNALING_STATE_CONNECT,
SIGNALING_STATE_READY | SIGNALING_STATE_DISCONNECTED | SIGNALING_STATE_CONNECTED | SIGNALING_STATE_JOIN_SESSION | SIGNALING_STATE_CONNECT,
fromConnectSignalingState, executeConnectSignalingState, defaultSignalingStateTransitionHook, INFINITE_RETRY_COUNT_SENTINEL,
Expand Down
2 changes: 2 additions & 0 deletions src/source/Stun/Stun.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,8 @@ STATUS deserializeStunPacket(PBYTE pStunBuffer, UINT32 bufferSize, PBYTE passwor
BOOL fingerprintFound = FALSE, messaageIntegrityFound = FALSE;
PBYTE pData, pTransaction;

UNUSED_PARAM(pStunAttributeFingerprint);

CHK(pStunBuffer != NULL && ppStunPacket != NULL, STATUS_NULL_ARG);
CHK(bufferSize >= STUN_HEADER_LEN, STATUS_INVALID_ARG);

Expand Down
16 changes: 8 additions & 8 deletions tst/IngestionFunctionalityTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ TEST_F(IngestionFunctionalityTest, basicCreateConnectJoinSession)
EXPECT_EQ(1, describeCount);
EXPECT_EQ(1, describeMediaCount);
EXPECT_EQ(1, getEndpointCount);
EXPECT_EQ(0, getIceConfigCount);
EXPECT_EQ(1, getIceConfigCount);

EXPECT_EQ(1, connectCount);

Expand Down Expand Up @@ -466,7 +466,7 @@ TEST_F(IngestionFunctionalityTest, iceReconnectEmulationWithJoinSession)
EXPECT_EQ(1, describeCount);
EXPECT_EQ(1, describeMediaCount);
EXPECT_EQ(1, getEndpointCount);
EXPECT_EQ(0, getIceConfigCount);
EXPECT_EQ(1, getIceConfigCount);
EXPECT_EQ(1, connectCount);

// This channel has ENABLED status so we should be calling join session
Expand Down Expand Up @@ -508,7 +508,7 @@ TEST_F(IngestionFunctionalityTest, iceReconnectEmulationWithJoinSession)
EXPECT_EQ(1, describeCount);
EXPECT_EQ(1, describeMediaCount);
EXPECT_EQ(1, getEndpointCount);
EXPECT_EQ(1, getIceConfigCount);
EXPECT_EQ(2, getIceConfigCount);
EXPECT_EQ(2, connectCount);

// This channel has ENABLED status so we should be calling join session
Expand Down Expand Up @@ -583,7 +583,7 @@ TEST_F(IngestionFunctionalityTest, iceServerConfigRefreshNotConnectedJoinSession
EXPECT_EQ(0, signalingStatesCounts[SIGNALING_CLIENT_STATE_CREATE]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_GET_ENDPOINT]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_GET_ICE_CONFIG]);
EXPECT_EQ(2, signalingStatesCounts[SIGNALING_CLIENT_STATE_READY]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_READY]);
EXPECT_EQ(0, signalingStatesCounts[SIGNALING_CLIENT_STATE_CONNECTING]);
EXPECT_EQ(0, signalingStatesCounts[SIGNALING_CLIENT_STATE_CONNECTED]);
EXPECT_EQ(0, signalingStatesCounts[SIGNALING_CLIENT_STATE_JOIN_SESSION]);
Expand Down Expand Up @@ -612,7 +612,7 @@ TEST_F(IngestionFunctionalityTest, iceServerConfigRefreshNotConnectedJoinSession
EXPECT_EQ(0, signalingStatesCounts[SIGNALING_CLIENT_STATE_CREATE]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_GET_ENDPOINT]);
EXPECT_LT(2, signalingStatesCounts[SIGNALING_CLIENT_STATE_GET_ICE_CONFIG]);
EXPECT_EQ(2, signalingStatesCounts[SIGNALING_CLIENT_STATE_READY]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_READY]);
EXPECT_EQ(0, signalingStatesCounts[SIGNALING_CLIENT_STATE_CONNECTING]);
EXPECT_EQ(0, signalingStatesCounts[SIGNALING_CLIENT_STATE_CONNECTED]);
EXPECT_EQ(0, signalingStatesCounts[SIGNALING_CLIENT_STATE_JOIN_SESSION]);
Expand All @@ -634,8 +634,8 @@ TEST_F(IngestionFunctionalityTest, iceServerConfigRefreshNotConnectedJoinSession

EXPECT_EQ(0, signalingStatesCounts[SIGNALING_CLIENT_STATE_CREATE]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_GET_ENDPOINT]);
EXPECT_LT(2, signalingStatesCounts[SIGNALING_CLIENT_STATE_GET_ICE_CONFIG]);
EXPECT_EQ(3, signalingStatesCounts[SIGNALING_CLIENT_STATE_READY]);
EXPECT_LT(3, signalingStatesCounts[SIGNALING_CLIENT_STATE_GET_ICE_CONFIG]);
EXPECT_EQ(2, signalingStatesCounts[SIGNALING_CLIENT_STATE_READY]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_CONNECTING]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_CONNECTED]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_JOIN_SESSION]);
Expand Down Expand Up @@ -726,7 +726,7 @@ TEST_F(IngestionFunctionalityTest, iceServerConfigRefreshConnectedJoinSessionWit
// We should not be calling create because it's pre-created at the start of the test
EXPECT_EQ(0, signalingStatesCounts[SIGNALING_CLIENT_STATE_CREATE]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_GET_ENDPOINT]);
EXPECT_EQ(0, signalingStatesCounts[SIGNALING_CLIENT_STATE_GET_ICE_CONFIG]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_GET_ICE_CONFIG]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_READY]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_CONNECTING]);
EXPECT_EQ(1, signalingStatesCounts[SIGNALING_CLIENT_STATE_CONNECTED]);
Expand Down
2 changes: 0 additions & 2 deletions tst/JitterBufferFunctionalityTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,11 +1137,9 @@ TEST_F(JitterBufferFunctionalityTest, timestampOverflowTest)
UINT32 pktCount = 7;
UINT32 startingSequenceNumber = 0;
UINT32 missingSequenceNumber = 0;
UINT32 firstSequenceNumber = 0;
initializeJitterBuffer(4, 0, pktCount);
srand(time(0));
startingSequenceNumber = rand()%UINT16_MAX;
firstSequenceNumber = startingSequenceNumber - 1;

// First frame "1"
mPRtpPackets[0]->payloadLength = 1;
Expand Down
Loading
Loading