-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.11.0 Release #2018
Merged
Merged
v1.11.0 Release #2018
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1eaede8
Release 1.10.0 (#1910)
disa6302 f107343
Viewer fix (#1953)
disa6302 4f1d3ad
Release 1.10.2 (#1981)
niyatim23 b54d180
addIceServerConfig revert
disa6302 c93c47c
CI
disa6302 323d91d
UT fixes, unused var
disa6302 936f5ec
one more unused
disa6302 b2162c6
version update
disa6302 4cd8eed
port static build fix prodc
hassanctech 6bc0d2d
build fixes, remove call to timer queue kick
hassanctech 4b5ed47
update mbedtls to latest LTS in 2.28 track
hassanctech e40fab5
Update libwebsockets-CMakeLists.txt
hassanctech ad2922a
fix mac build mbedtls, add option for ca cert
hassanctech 38e942c
need to add definition so it can be used downstream even if it was sp…
hassanctech 3652e86
Default ENABLE_KVS_THREADPOOL to OFF
stefankiesz df7f38b
Update README.md to reflect threadpool changes
stefankiesz 096cafe
Add cmake flag for iot creds (#2056)
sirknightj e22e08b
Prepare for 1.11.0 release.
stefankiesz d9ab52d
Add instructions for using IoT credentials in the samples and documen…
sirknightj d5d09c8
Change branch target from master to main (#2059)
sirknightj 77e2c47
Merge branch 'main' into 1.10.3
hassanctech 86aed1d
Update libkvsCommonLws-CMakeLists.txt to new release
stefankiesz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,6 +105,8 @@ message(STATUS "dependencies install path is ${OPEN_SRC_INSTALL_PREFIX}") | |
|
||
if(NOT DEFINED KVS_CA_CERT_PATH) | ||
add_definitions(-DKVS_CA_CERT_PATH="${CMAKE_SOURCE_DIR}/certs/cert.pem") | ||
else() | ||
add_definitions(-DKVS_CA_CERT_PATH="${KVS_CA_CERT_PATH}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note for later: Let's see if we can make this a runtime parameter option as well. |
||
endif() | ||
|
||
add_definitions(-DCMAKE_DETECTED_CACERT_PATH) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How was it working, before this addition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Customers could specify an environment variable as well, or they would make the change in the CMakeLists themselves manually, or when you're running from the sample place it was built, the path will be right.