-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Kvssink deliver-images with putEventMetadata #1176
base: develop-pre-3.4.1
Are you sure you want to change the base?
Conversation
As discussed in the other PR, please adjust to every N keyframes to make this feature more flexible. Also, please edit PR title, description, GStreamer parameter description, etc to clearly mark that this feature is explicitly for s3 image delivery. The s3 delivery mkv simple tag is not needed for image generation through GetImages, and thus, "image generation" is already supported in its current state. For completeness, can you also share an outline of the procedure you used to verify the tag was added and a screenshot of some media with the tag. |
Discussed offline waiting for a change here to trigger a call to the put event metadata API based on receiving GST_EVENT_CUSTOM_DOWNSTREAM similar to the put fragment metadata API. |
I will push for keeping consistent with the docs and calling this image delivery to avoid confusion with the other feature getimages https://docs.aws.amazon.com/kinesisvideostreams/latest/dg/gs-getImages.html Also, please update the readme as there is no information about how to use it. |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Issue #, if available:
What was changed?
Why was it changed?
How was it changed?
What testing was done for the changes?
Tested the following locally:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.