-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvssink hard start/stop support #1120
base: develop-pre-3.4.1
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1120 +/- ##
===========================================
+ Coverage 16.38% 16.59% +0.21%
===========================================
Files 51 51
Lines 6849 6973 +124
===========================================
+ Hits 1122 1157 +35
- Misses 5727 5816 +89 ☔ View full report in Codecov by Sentry. |
Tested using: kvssink sample to start/stop the stream at various intervals including:
The stream was inspected for successful ingestion at each playing stage.
Long-term memory consumption still needs to be verified.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.