Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvssink hard start/stop support #1120

Draft
wants to merge 16 commits into
base: develop-pre-3.4.1
Choose a base branch
from

Conversation

stefankiesz
Copy link
Contributor

Tested using: kvssink sample to start/stop the stream at various intervals including:

  • ~100 times in a run with 0s interval between start/stops
  • play 5s -> sleep 5s -> play 20s -> sleep 60s -> play 20s -> sleep 20min -> play onward

The stream was inspected for successful ingestion at each playing stage.

Long-term memory consumption still needs to be verified.



By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

Attention: 237 lines in your changes are missing coverage. Please review.

Comparison is base (6af9a7a) 16.38% compared to head (e78ea19) 16.59%.
Report is 4 commits behind head on develop.

❗ Current head e78ea19 differs from pull request most recent head 3e63221. Consider uploading reports for the commit 3e63221 to get more accurate results

Files Patch % Lines
samples/kvssink_gstreamer_sample.cpp 0.00% 106 Missing ⚠️
samples/gstreamer_sandbox.cpp 0.00% 66 Missing ⚠️
src/gstreamer/gstkvssink.cpp 0.00% 56 Missing ⚠️
samples/kvs_gstreamer_audio_video_sample.cpp 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1120      +/-   ##
===========================================
+ Coverage    16.38%   16.59%   +0.21%     
===========================================
  Files           51       51              
  Lines         6849     6973     +124     
===========================================
+ Hits          1122     1157      +35     
- Misses        5727     5816      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sirknightj sirknightj added the gstreamer Changes to kvssink or the kvssink samples label Feb 21, 2024
@stefankiesz stefankiesz changed the title Add kvssink start/stop support kvssink hard start/stop support Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gstreamer Changes to kvssink or the kvssink samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants