telemetry: add notifications telemetry #5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Nov 8, 2024
Comment on lines
212
to
217
| telemetry.ui_click.emit({ | ||
| elementId: `${getNotificationTelemetryId(notification)}:DISMISS`, | ||
| result: 'Succeeded', | ||
| }) | ||
|
|
||
| await NotificationsController.instance.dismissNotification(notification.id) |
There was a problem hiding this comment.
is it worth forming it as a run() around this call?
justinmk3
reviewed
Nov 8, 2024
| elementId: getNotificationTelemetryId(n), | ||
| result: 'Succeeded', | ||
| }) | ||
| return this.openNotification(n) |
There was a problem hiding this comment.
telemetry.ui_click.run() ?
justinmk3
reviewed
Nov 8, 2024
| await openUrl(vscode.Uri.parse(selectedButton.url)) | ||
| } else { | ||
| throw new ToolkitError('url not provided') | ||
| return vscode.window |
There was a problem hiding this comment.
Future: could use #5776 here.
justinmk3
approved these changes
Nov 8, 2024
2 tasks
I explored sending telemetry if the user hides or unhides the notification view panel. However, there is no VSC hook to detect this and other ways (e.g. checking visible property) are not reliable. So, we cannot track this. - toolkit_showNotification - for displaying notifications on receive or when clicked on - toolkit_invokeAction - invoking an action from a notification, e.g. clicking on a button in the notification or opening a text document - ui_click for clicking on the notifications node or dismiss button
hayemaxi
force-pushed
the
notifications-2
branch
from
30aa78e
to
61fdbe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I explored sending telemetry if the user hides or unhides the notification view panel. However, there is no VSC hook to detect this and other ways (e.g. checking visible property) are not reliable. So, we cannot track this.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.