Display startup and emergency notifications #5143
Conversation
…ifications(#5097) * Display toast notifications with actions * Condition matcher for displaying notifications * Show notification banner * feedback 1 * Modified deserialization cases and added tests * not required file change * feedback 1 * feedback 1 * modified the base class * merge conflicts resolved * rearranged call site * show notifications when panel is opened * fixed tests * detekt * feedback * convert panels into wrappers * fixed test
* initial commit * run on startup * detekt * move vals * remote resource implementation * comments * detekt * Validate file before saving * cache path * observer implementation * deserialize notifs from file * detekt * remove unused interface * internal class * Fix observer * etag singleton state component * add telemetry * atomicBoolean * initialize once per IDE startup * code scan * Omit (Unit) * specify etag storage location * detekt * fix detekt issues * basic tests * no star imports * coroutine scope delay instead of thread.sleep * feedback fixes * test fix * Application Exists for tests * endpoint object * detekt * detekt fixes * boolean flag * boolean flag * update tests * move startup flag handling to processBase * fix delay * fix delay * Notification dismissal state tracking (#5129) * split notifications into separated lists. * add persistent notification dismissal state logic * boolean changes * group persistant states * comments * Service initialized automatically * isStartup global * Deserialized notification schedule type * tests * persistent state syntax * convert to light services * Remove state from companion object * detekt * endpoint as registryKey * detekt * fix startup issues * Expiry issues
* add logs for polling and processing notifs * redundant * finish log
Qodana Community for JVM12 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import software.aws.toolkits.telemetry.FeatureId | ||
| import javax.swing.JComponent | ||
|
|
||
| class OuterAmazonQPanel(val project: Project) : BorderLayoutPanel() { |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
| updateQPanel(component) | ||
| } | ||
|
|
||
| fun updateQPanel(content: JComponent) { |
Check notice
Code scanning / QDJVMC
Class member can have 'private' visibility Note
|
|
||
| package software.aws.toolkits.jetbrains.core.notifications | ||
|
|
||
| object DisplayToastNotifications |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
| import software.aws.toolkits.jetbrains.core.DefaultRemoteResourceResolverProvider | ||
| import software.aws.toolkits.jetbrains.core.RemoteResourceResolverProvider | ||
| import software.aws.toolkits.telemetry.Component | ||
| import software.aws.toolkits.telemetry.ToolkitTelemetry |
Check warning
Code scanning / QDJVMC
Usage of redundant or deprecated syntax or deprecated symbols Warning
| import software.aws.toolkits.jetbrains.core.DefaultRemoteResourceResolverProvider | ||
| import software.aws.toolkits.jetbrains.core.RemoteResourceResolverProvider | ||
| import software.aws.toolkits.telemetry.Component | ||
| import software.aws.toolkits.telemetry.ToolkitTelemetry |
Check warning
Code scanning / QDJVMC
Usage of redundant or deprecated syntax or deprecated symbols Warning
| } | ||
|
|
||
| private fun emitFailureMetric(e: Exception?) { | ||
| ToolkitTelemetry.showNotification( |
Check warning
Code scanning / QDJVMC
Usage of redundant or deprecated syntax or deprecated symbols Warning
| notifyStickyWithData(notifyType, title, message, null, action, notificationId) | ||
| } | ||
|
|
||
| fun notifyListenerForNotification(bannerContent: BannerContent) = |
Check notice
Code scanning / QDJVMC
Class member can have 'private' visibility Note
| return shouldShow | ||
| } | ||
|
|
||
| fun matchesAllRules(notificationConditions: NotificationDisplayCondition, project: Project): Boolean { |
Check notice
Code scanning / QDJVMC
Class member can have 'private' visibility Note
| import software.aws.toolkits.jetbrains.utils.isTookitConnected | ||
| import javax.swing.JComponent | ||
|
|
||
| class OuterToolkitPanel(val project: Project) : BorderLayoutPanel() { |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
| updateToolkitPanel(component) | ||
| } | ||
|
|
||
| fun updateToolkitPanel(content: JComponent) { |
Check notice
Code scanning / QDJVMC
Class member can have 'private' visibility Note
Types of changes
Description
Display in-IDE notifications
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.