fix(amazonq): add field for builderId vs IdC #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhasani23
commented
Apr 8, 2024
| @@ -143,19 +143,13 @@ class CodeModernizerSession( | |||
| LOG.warn { "Job was cancelled by user before start job was called" } | |||
| CodeModernizerStartJobResult.Cancelled | |||
| } else { | |||
| val errorMessage = "Failed to start job" | |||
| LOG.error(e) { errorMessage } | |||
There was a problem hiding this comment.
This was already being logged and emitted elsewhere
dhasani23
changed the title
mk-fan
reviewed
Apr 8, 2024
mk-fan
reviewed
Apr 8, 2024
...mmunity/src/software/aws/toolkits/jetbrains/services/codemodernizer/CodeModernizerSession.kt
Show resolved
Hide resolved
mk-fan
reviewed
Apr 8, 2024
...src/software/aws/toolkits/jetbrains/services/codemodernizer/CodeTransformTelemetryManager.kt
Outdated
Show resolved
Hide resolved
manodnyab
approved these changes
Apr 8, 2024
|
mk-fan
reviewed
Apr 8, 2024
| fun jobIsStartedFromChatPrompt() { | ||
| val connection = checkBearerConnectionValidity(project, BearerTokenFeatureSet.Q) | ||
| var authType: CredentialSourceId? = null | ||
| if (connection.connectionType == ActiveConnectionType.IAM_IDC && connection is ActiveConnection.ValidBearer) { |
There was a problem hiding this comment.
nit: Can probably check connection is ActiveConnection.ValidBearer as an outer if.
mk-fan
approved these changes
Apr 8, 2024
kumsmrit
pushed a commit
to kumsmrit/aws-toolkit-jetbrains
that referenced
this pull request
Apr 16, 2024
* fix(amazonq): improve telemetry * remove unused import * address comments * fix detekt issue --------- Co-authored-by: David Hasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Need to track if users using builderId or IdC for
/transform. Had some redundant telemetry/logging. Deleted dead code too.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.