-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added unit tests for Q FeatureDev planning phase #4235
Conversation
@@ -28,7 +28,7 @@ class Session(val tabID: String, val project: Project) { | |||
private var _conversationId: String? = null | |||
private var _latestMessage: String = "" | |||
private var task: String = "" | |||
private val proxyClient: FeatureDevClient | |||
var proxyClient: FeatureDevClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does not need to be made public
just use project.replaceService
to stub the client for tests
@@ -9,6 +9,7 @@ import com.intellij.openapi.project.modules | |||
import com.intellij.openapi.vfs.VirtualFile | |||
import com.intellij.testFramework.DisposableRule | |||
import com.intellij.testFramework.replaceService | |||
import org.gradle.internal.impldep.com.amazonaws.ResponseMetadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont reference gradle shadow libraries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please suggest, how to populate responseMetadata
then; as I see similar reference in CodeWhisperer and Gumby tests ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
software.amazon.awssdk.awscore.util.AwsHeader
or declare a const somewhere
they're in codewhisperer and gumby because someone added it and then everyone after copied it
|
||
@Test | ||
fun `test new tab opened`() { | ||
val message: IncomingFeatureDevMessage.NewTabCreated = IncomingFeatureDevMessage.NewTabCreated("new-tab-created", tabId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type declaration is not needed
val message: IncomingFeatureDevMessage.NewTabCreated = IncomingFeatureDevMessage.NewTabCreated("new-tab-created", tabId) | |
val message = IncomingFeatureDevMessage.NewTabCreated("new-tab-created", tabId) |
@@ -28,7 +28,7 @@ class Session(val tabID: String, val project: Project) { | |||
private var _conversationId: String? = null | |||
private var _latestMessage: String = "" | |||
private var task: String = "" | |||
private val proxyClient: FeatureDevClient | |||
private var proxyClient: FeatureDevClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private var proxyClient: FeatureDevClient | |
private val proxyClient: FeatureDevClient |
cc7e2af
to
8f1a5b6
Compare
8f1a5b6
to
f65a06b
Compare
Quality Gate passedIssues Measures |
* feat: Added unit tests for FeatureDev planning phase
Types of changes
Description
Added unit tests for Q FeatureDev for the plan generation phase
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.