Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore - Refactor utils files #4220

Merged
merged 17 commits into from
Apr 9, 2024
Merged

Conversation

damntrecky
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Refactor our service utils into separate files for separation of concerns. We have upcoming changes that will be affected by this.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@damntrecky damntrecky requested review from a team as code owners March 29, 2024 22:29
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@damntrecky damntrecky enabled auto-merge (squash) April 9, 2024 16:35
@damntrecky damntrecky merged commit f8811a9 into aws:main Apr 9, 2024
9 of 11 checks passed
sarayev pushed a commit to sarayev/aws-toolkit-jetbrains that referenced this pull request Apr 10, 2024
* Chore - refactor util files for separation of concerns
kumsmrit pushed a commit to kumsmrit/aws-toolkit-jetbrains that referenced this pull request Apr 16, 2024
* Chore - refactor util files for separation of concerns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants