adding scopes to auth metrics for detailed authStatus #736
Conversation
| "name": "auth_userState", | ||
| "description": "The state of the user's authentication.", |
There was a problem hiding this comment.
metrics are for events. state isn't an event
What event does auth_userState represent? It looks more like data. Can the data be stored on an existing event? Otherwise, it's not clear when this "event" should be emitted, it would be more like a heartbeat (which then implies it should be on... an existing, semi-frequent event)
If this is to be done on startup, can it be added to the existing startup event?
There was a problem hiding this comment.
it's only on startup.
There was a problem hiding this comment.
I see that this is upstreaming an existing metric: https://github.com/aws/aws-toolkit-vscode/blob/0f9782a9d8407d3d755c44dc3a3eec1fe405e7b9/packages/core/src/shared/telemetry/vscodeTelemetry.json#L1108-L1109
There was a problem hiding this comment.
yes Ideally it should be in common only because JetBrains is also emitting this metric. Trying to fix it by moving it to common.
Problem
Adding auth telemetry for to identify user's auth Status upon start up.
Solution
auth_userState list scopes upon users loading extension so we know their authStatus upon startup
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.