Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry(amazonq): source folder modification #731

Merged
merged 1 commit into from
May 13, 2024

Conversation

sannicm
Copy link
Contributor

@sannicm sannicm commented May 6, 2024

Problem

The source folder modification was not being tracked, it was evident when a bug was spotted and it was not possible to measure any customer impact. This should make it easier when integrated with the toolkits to measure usage and impact if something goes wrong.

Solution

Add modifySourceFolder metric.

It was tested in the VSCode toolkit adding the metric in vscodeTelemetry.json file, generating telemetry and then checking it was emitted in kibana.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sannicm sannicm requested a review from a team as a code owner May 6, 2024 14:25
@justinmk3
Copy link
Contributor

what does "The source folder modification" mean? Is this referring to when the user changes the vscode workspace folder, or something else?

If it's referring to a vscode operation, then the metric should have a more generic prefix such as ide_ or vscode_

@sannicm
Copy link
Contributor Author

sannicm commented May 7, 2024

@justinmk3

what does "The source folder modification" mean? Is this referring to when the user changes the vscode workspace folder, or something else?

If it's referring to a vscode operation, then the metric should have a more generic prefix such as ide_ or vscode_

It referst to a /dev feature to let the customer reduce the amount of folders (reducing the context) to upload for code generation. The usage was not being tracked and there was a bug on this feature. TLDR it is not the vscode's/ide's feature.

@sannicm sannicm force-pushed the sannicm/modifySourceFolderMetric branch from 78f6b61 to 2308ee3 Compare May 7, 2024 08:21
@sannicm sannicm requested review from jsalles and justinmk3 May 7, 2024 12:46
@justinmk3
Copy link
Contributor

It referst to a /dev feature to let the customer reduce the amount of folders (reducing the context) to upload for code generation. The usage was not being tracked and there was a bug on this feature

Wouldn't that make sense as some sort of "count" field on the existing on the "upload" or "generate" metric (amazonq_codeGenerationInvoke or whatever the right one is)? Why emit a new metric for this?

@sannicm
Copy link
Contributor Author

sannicm commented May 13, 2024

It referst to a /dev feature to let the customer reduce the amount of folders (reducing the context) to upload for code generation. The usage was not being tracked and there was a bug on this feature

Wouldn't that make sense as some sort of "count" field on the existing on the "upload" or "generate" metric (amazonq_codeGenerationInvoke or whatever the right one is)? Why emit a new metric for this?

@justinmk3 This is completely unrelated to the code generation invocation or planning. /dev is calculating the size of the repo before uploading and there is no visibility on the usage of the feature that allows the customer to modify a source folder for retrying generation. This will emit a metric when specficially this feature is used.

@sannicm sannicm force-pushed the sannicm/modifySourceFolderMetric branch from 2308ee3 to 33bd855 Compare May 13, 2024 15:11
@justinmk3

This comment was marked as resolved.

@@ -1598,6 +1598,19 @@
}
]
},
{
"name": "amazonq_modifySourceFolder",
"description": "User modified source folder",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could happen on different steps of our process, whenever we upload the repo to our backend (that happens at least once before planning the execution, and once more for each code generation requested).
It is kinda like a sub-command of /dev but it’s not triggered by the user whenever they want, and only when we think the repo is too large and a sub-folder should be selected.
We display the button and want to capture the action of the user clicking it.

@justinmk3 justinmk3 changed the title feat: add metric for tracking source folder modification telemetry(amazonq): source folder modification May 13, 2024
@justinmk3 justinmk3 merged commit b32fc9f into aws:main May 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants