telemetry: add new field for prev status #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damntrecky
reviewed
Mar 7, 2024
| @@ -282,6 +282,11 @@ | |||
| "RemoteRunProject" | |||
| ] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Question: Are you adding this new type to a metric? Will need to define that here as well.
There was a problem hiding this comment.
Oh shoot forgot to do that, fixing now
mk-fan
approved these changes
Mar 7, 2024
dhruvigajjar
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We already have a status field, but also want to be able to track the previous status of a job so that we can see how the status changes over time more easily. Using a new field rather than putting it all in the existing status field because our dashboards and other metrics are already configured to visualize the status with the existing field, so don't want to break that.
Solution
Add new field to hold job's previous status.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.