Skip to content

Commit

Permalink
feat: add general latency metrics (#913)
Browse files Browse the repository at this point in the history
## Problem
- Soooooooooo many teams have specific latency metric fields and many
are asking to add them for re-invent

## Solution
- De-dup a lot of them e.g. amazonqGenerateApproachLatency,
amazonqGenerateCodeResponseLatency, amazonqEndOfTheConversationLatency,
etc

## Other notes
- amazonq_approachInvoke would then have perfServerLatency instead of an
individual amazonqGenerateApproachLatency field
- amazonq_codeGenerationInvoke would then have perfServerLatency instead
of an individual amazonqGenerateCodeResponseLatency field
- amazonq_endChat would then have perfE2ELatency instead of an
individual amazonqEndOfTheConversationLatency field

- In the future we can re-use the perfClientLatency metric for tracking
the duration of different events that only happen in the client side
(e.g. how long the client latency takes in the amazon q chat flow)
  • Loading branch information
jpinkney-aws authored Nov 14, 2024
1 parent f851093 commit 608571e
Showing 1 changed file with 17 additions and 2 deletions.
19 changes: 17 additions & 2 deletions telemetry/definitions/commonDefinitions.json
Original file line number Diff line number Diff line change
Expand Up @@ -1145,7 +1145,7 @@
"remoteDesktop",
"ssh",
"scp",
"ssm",
"ssm",
"remoteWorkspace"
],
"description": "Ways to connect to an EC2 Instance"
Expand Down Expand Up @@ -1488,6 +1488,21 @@
"type": "int",
"description": "Number of generation paths modified"
},
{
"name": "perfClientLatency",
"type": "double",
"description": "The time duration in milliseconds to process an action on the client side"
},
{
"name": "perfE2ELatency",
"type": "double",
"description": "The time duration in milliseconds to complete an end to end flow"
},
{
"name": "perfServerLatency",
"type": "double",
"description": "The time duration in milliseconds to finish a request to the server side"
},
{
"name": "platform",
"type": "string",
Expand Down Expand Up @@ -7069,4 +7084,4 @@
]
}
]
}
}

0 comments on commit 608571e

Please sign in to comment.