Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove ruby2.7 support #6666

Merged
merged 3 commits into from
Feb 8, 2024
Merged

chore: Remove ruby2.7 support #6666

merged 3 commits into from
Feb 8, 2024

Conversation

hnnasit
Copy link
Contributor

@hnnasit hnnasit commented Feb 8, 2024

Why is this change necessary?

Deprecate runtime ruby2.7 already deprecated by AWS Lambda

How does it address the issue?

Removes all occurrences of ruby2.7

What side effects does this change have?

No side effects

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added area/local/start-api sam local start-api command area/build sam build command area/local/invoke sam local invoke command area/local/start-invoke area/schema JSON schema file pr/internal labels Feb 8, 2024
@hnnasit hnnasit changed the base branch from develop to test/ruby27 February 8, 2024 21:55
@hnnasit hnnasit marked this pull request as ready for review February 8, 2024 21:55
@hnnasit hnnasit requested a review from a team as a code owner February 8, 2024 21:55
@hnnasit hnnasit requested review from hawflau and bentvelj and removed request for a team February 8, 2024 21:55
@hnnasit hnnasit merged commit 61f3a68 into aws:test/ruby27 Feb 8, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawflau hawflau Awaiting requested review from hawflau hawflau is a code owner automatically assigned from aws/serverless-application-experience-sbt

@bentvelj bentvelj Awaiting requested review from bentvelj bentvelj is a code owner automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke area/schema JSON schema file pr/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hnnasit