Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getting logging information from lambda #6475

Closed
wants to merge 5 commits into from

Conversation

mndeveci
Copy link
Contributor

Which issue(s) does this change fix?

#6466

Why is this change necessary?

sam logs fails to pull the log for a function which has LoggingConfig set.

How does it address the issue?

By fixing the API call and updating boto3 library which contains this information.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci marked this pull request as ready for review December 20, 2023 21:43
@mndeveci mndeveci requested a review from a team as a code owner December 20, 2023 21:43
@mndeveci mndeveci requested review from moelasmar and jysheng123 and removed request for moelasmar December 20, 2023 21:43
@mndeveci mndeveci closed this Dec 21, 2023
@mndeveci
Copy link
Contributor Author

Superseded by #6477

@mndeveci mndeveci deleted the fix_custom_log_config branch December 21, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant