Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bump AWS::Serverless::Function runtime to nodejs18.x #6196

Merged
merged 7 commits into from
Nov 8, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 2, 2023

Which issue(s) does this change fix?

Fixes: #6195

Why is this change necessary?

Lambda nodejs14.x creation will be stopped on Nov 27, 2023.

How does it address the issue?

Bumps AWS::Serverless::Function runtime to nodejs18.x

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 2, 2023
@trivikr trivikr force-pushed the lambda-node14-to-node18 branch from 632155b to b7cdcd6 Compare November 2, 2023 22:50
@trivikr trivikr marked this pull request as ready for review November 2, 2023 23:02
@trivikr trivikr requested a review from a team as a code owner November 2, 2023 23:02
@trivikr trivikr requested review from mildaniel and hnnasit November 2, 2023 23:02
@moelasmar moelasmar closed this Nov 3, 2023
@moelasmar moelasmar reopened this Nov 3, 2023
Copy link
Contributor

@hawflau hawflau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@hawflau hawflau added this pull request to the merge queue Nov 8, 2023
Merged via the queue into aws:develop with commit 7d39ecb Nov 8, 2023
91 of 109 checks passed
@trivikr trivikr deleted the lambda-node14-to-node18 branch November 8, 2023 18:19
@trivikr
Copy link
Member Author

trivikr commented Nov 8, 2023

I missed updating node 16, and <12 versions to 18 in this PR.

I'll post separate PRs for each bump, so that any version bump specific issues can be resolved in those PRs.
The nodejs 16.x > 18.x PR is at #6227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Upgrade Lambda Functions to use nodejs18.x
3 participants