chore: improve java arm64 build tests #6081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mndeveci
changed the title
hawflau
approved these changes
Oct 13, 2023
mildaniel
approved these changes
Oct 16, 2023
moelasmar
pushed a commit
to moelasmar/aws-sam-cli
that referenced
this pull request
Oct 22, 2023
* test build image performance changes * move back to original folder * fix timeout during local invoke * test conftest * set timeout to 300s * log info * pull arm64 images before hand * only pull them before running arm64 tests * decrease timeout and increase retries for local invoke * run all build tests * fix the output check for local invoke * re-run tests with gradle improvements * revert appveyor-ubuntu.yml
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During build integration tests, we run
samdev buildand thensamdev local invoketo validate the build results. For somearm64build tests (mostly java runtimes) having issues when validating the build result withsam local invoke, which gets stuck.This PR addresses that issue by decreasing the timeout time of the function so that it can time out earlier (changed from 10mins to 1min), and also adds retries to
samdev local invokemethod so that if previous invocation is stuck, it can retry.This change improves running Java arm64 tests to ~90mins;
It also slightly improves rest of the arm64 tests (example run completed in 33mins);
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.