Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add runtime markers to base classes in build tests #6044

Merged
merged 11 commits into from
Oct 10, 2023

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Oct 5, 2023

Which issue(s) does this change fix?

N/A

Marks build tests by their runtimes and splits their workers so that they can complete under 90minutes (except arm64 ones due to retries).

  • Creates following markers for build test: ruby, nodejs, golang, java, python, provided and dotnet.
  • Splits x86 build tests for Java, Python and Provided runtimes into one group, and leaves the rest in the original build tests group for both Linux and Windows.
  • Splits arm64 tests for Java only for Linux (Windows tests complete in ~50mins, no need to split for now)
  • Removed some duplicate LOG.info for printing the command details.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci marked this pull request as ready for review October 10, 2023 17:24
@mndeveci mndeveci requested a review from a team as a code owner October 10, 2023 17:24
@mndeveci mndeveci requested review from hawflau and hnnasit October 10, 2023 17:24
@mndeveci mndeveci added this pull request to the merge queue Oct 10, 2023
Merged via the queue into aws:develop with commit 7203b09 Oct 10, 2023
76 checks passed
moelasmar pushed a commit to moelasmar/aws-sam-cli that referenced this pull request Oct 22, 2023
* chore: add runtime markers to base classes in build tests

* use nodejs for esbuild and add dotnet one

* test per runtime per arch

* fix ruby job naming issue

* cleanup and tag some tests with python

* group tests balanced

* bring other jobs into appveyor files again

* merge package & delete test runners

* apply changes to binary runners

* ignore deprecation warning from urllib3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants