fix: gracefully exit on not finding a local image #6039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mndeveci
approved these changes
Oct 4, 2023
hawflau
approved these changes
Oct 4, 2023
sriram-mv
force-pushed
the
graceful_fail_docker_image_pull_build
branch
from
8f47580 to
dcc55c1
Compare
- For `build` with `--use-container` and `--build-image`
sriram-mv
force-pushed
the
graceful_fail_docker_image_pull_build
branch
from
dcc55c1 to
c216a61
Compare
moelasmar
pushed a commit
to moelasmar/aws-sam-cli
that referenced
this pull request
Oct 22, 2023
- For `build` with `--use-container` and `--build-image`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildwith--use-containerand--build-imageWhich issue(s) does this change fix?
#6023
Why is this change necessary?
Gracefully fail and not throw a traceback
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.