-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Refactor Terraform Build Tests #6013
Merged
mildaniel
merged 23 commits into
aws:develop
from
mildaniel:update-terraform-testing-procedure
Oct 3, 2023
Merged
test: Refactor Terraform Build Tests #6013
mildaniel
merged 23 commits into
aws:develop
from
mildaniel:update-terraform-testing-procedure
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: Refactor Terraform build tests * Change function identifier
* test: Refactor Terraform build tests * Change function identifier * Fix S3 issues
* test: Refactor Terraform build tests * Change function identifier * Fix S3 issues * Test Windows all Terraform tests
…aform-testing-procedure
…niel/aws-sam-cli into update-terraform-testing-procedure
mndeveci
reviewed
Sep 29, 2023
tests/integration/buildcmd/test_build_terraform_applications.py
Outdated
Show resolved
Hide resolved
lucashuy
approved these changes
Oct 3, 2023
mndeveci
approved these changes
Oct 3, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
N/A
Why is this change necessary?
Currently, the Terraform-related build tests continuously re-build the same function code using the same build method for 30+ functions in several different test classes. This is redundant and takes a long time to execute without providing much additional validation. Currently, 5 workers are required to run these tests on AppVeyor with the longest test class taking over an hour.
This PR reworks the way these tests are executed in a way that requires a single runner with all tests being completed in < 1 hour.
How does it address the issue?
Instead the new testing flow is:
template.yaml
file.Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.