Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure template output is actually parsable data #6005

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Sep 28, 2023

Which issue(s) does this change fix?

#5955

Why is this change necessary?

A change was made to a template fetching method a while back that updated the returned value from the API to be a string instead of a dictionary. The API call itself can return either a string, or a dictionary.

The method did not account for the returned data from the API being a dictionary, and instead the string representation of a Python dictionary object was returned, instead of a JSON formatted string.

How does it address the issue?

Updates the method to return a JSON formatted string if it is a dictionary type.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucashuy lucashuy marked this pull request as ready for review September 28, 2023 22:59
@lucashuy lucashuy requested a review from a team as a code owner September 28, 2023 22:59
@lucashuy lucashuy added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 3, 2023
@lucashuy lucashuy enabled auto-merge October 3, 2023 20:20
@lucashuy lucashuy added this pull request to the merge queue Oct 3, 2023
Merged via the queue into aws:develop with commit 4b682b2 Oct 3, 2023
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants