Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add sqs boto-stubs which is used for remote invoke SQS #5997

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

hnnasit
Copy link
Contributor

@hnnasit hnnasit commented Sep 27, 2023

Which issue(s) does this change fix?

N/A

Why is this change necessary?

This change is necessary to add sqs boto3 stubs which will be used for remote invoke SQS. The GitHub action that runs and validates reproducible does not run on PRs created from forked branches. This change is necessary for the PR #5987.

How does it address the issue?

Adds sqs boto3-stub dependency

What side effects does this change have?

No side effects

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hnnasit hnnasit closed this Sep 27, 2023
@hnnasit hnnasit reopened this Sep 27, 2023
@hnnasit hnnasit closed this Sep 27, 2023
@hnnasit hnnasit reopened this Sep 27, 2023
@hnnasit hnnasit closed this Sep 27, 2023
@hnnasit hnnasit reopened this Sep 27, 2023
@hnnasit hnnasit marked this pull request as ready for review September 27, 2023 21:04
@hnnasit hnnasit requested a review from a team as a code owner September 27, 2023 21:04
@hnnasit hnnasit requested review from jfuss and moelasmar September 27, 2023 21:04
@hnnasit hnnasit added this pull request to the merge queue Sep 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 29, 2023
@hnnasit hnnasit added this pull request to the merge queue Sep 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 29, 2023
@hnnasit hnnasit enabled auto-merge September 29, 2023 15:29
@hnnasit hnnasit added this pull request to the merge queue Sep 29, 2023
Merged via the queue into develop with commit 6829d37 Sep 29, 2023
79 checks passed
@hnnasit hnnasit deleted the add-sqs-boto3-stub branch September 29, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants