Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gracefully handle when git executable can't be found #5988

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Sep 26, 2023

Which issue(s) does this change fix?

#5983

Why is this change necessary?

When checking git executable, SAM CLI raises OSError which causes hard fail.

How does it address the issue?

This replaces OSError with a custom one which extends from UserError. This will display a better warning message rather than splitting the whole exception trace.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci marked this pull request as ready for review September 26, 2023 19:00
@mndeveci mndeveci requested a review from a team as a code owner September 26, 2023 19:00
@mndeveci mndeveci requested review from lucashuy and jfuss September 26, 2023 19:00
@mndeveci mndeveci added this pull request to the merge queue Sep 26, 2023
Merged via the queue into aws:develop with commit aadeb3a Sep 26, 2023
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants