[EC] Unify scalar_mul_public for ec_nistp curves #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkostic
force-pushed
the
ec-nistp-scalar-mul-public-v2
branch
from
c034744
to
db30820
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2004 +/- ##
=======================================
Coverage 78.89% 78.89%
=======================================
Files 595 594 -1
Lines 102451 102380 -71
Branches 14527 14508 -19
=======================================
- Hits 80827 80772 -55
+ Misses 20976 20958 -18
- Partials 648 650 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
nebeid
reviewed
Nov 21, 2024
Co-authored-by: Nevine Ebeid <[email protected]>
Co-authored-by: Nevine Ebeid <[email protected]>
dkostic
force-pushed
the
ec-nistp-scalar-mul-public-v2
branch
from
db30820
to
12c1aec
Compare
nebeid
approved these changes
Nov 22, 2024
| ctx->felem_neg(ftmp, &g_table[idx * g_point_num_limbs + ctx->felem_num_limbs]); | ||
| y_tmp = ftmp; | ||
| } | ||
| ctx->point_add(x_out, y_out, z_out, x_out, y_out, z_out, 1, |
There was a problem hiding this comment.
Is the mixed flag explained elsewhere (re removing the comments that were before this step.)
There was a problem hiding this comment.
Samuel asked the same so I'll add the comment back in my next PR that's going to deal with point addition anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-2545
Description of changes:
Added unified scalar_mul_public implemented in ec_nistp.
This is a refactor of the algorithm in p384.c and p521.c
that makes it generic. The implementations in p384.c, p521.c,
as well as in p256.c, are substituted with this new unified
implementation.
Call-outs:
Builds on top of #2003
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.