-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for cipher auth with multiple cert slots #1956
Merged
samuel40791765
merged 3 commits into
aws:main
from
samuel40791765:multiple-certs-cipher
Nov 13, 2024
Merged
Account for cipher auth with multiple cert slots #1956
samuel40791765
merged 3 commits into
aws:main
from
samuel40791765:multiple-certs-cipher
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1956 +/- ##
==========================================
+ Coverage 78.86% 78.88% +0.01%
==========================================
Files 593 593
Lines 101933 101961 +28
Branches 14450 14454 +4
==========================================
+ Hits 80386 80427 +41
+ Misses 20903 20890 -13
Partials 644 644 ☔ View full report in Codecov by Sentry. |
samuel40791765
force-pushed
the
multiple-certs-cipher
branch
3 times, most recently
from
November 1, 2024 20:21
35a1680
to
3f53a7a
Compare
skmcgrail
reviewed
Nov 11, 2024
skmcgrail
previously approved these changes
Nov 12, 2024
samuel40791765
force-pushed
the
multiple-certs-cipher
branch
from
November 12, 2024 23:45
a9af715
to
19d003e
Compare
WillChilds-Klein
approved these changes
Nov 13, 2024
skmcgrail
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses
CryptoAlg-2699
Description of changes:
Ruby has a dependency on the multiple certificate slot mechanisms that OpenSSL allows for. We've already done the work to support this, but another Ruby 3.1 test has exposed a gap in our support. We were only depending on the negotiated signature algorithms to retrieve the right certificate for the server to send back, but the cipher authentication scheme was also checked in OpenSSL as well. Ruby's tests happen to only depend on configuring the authentication scheme which brought this to light.
We happen to do only do this when checking private keys for TLS 1.0/1.1 , this also fixes it to check the cipher against the initial public key. This change also introduces all of the mentioned cipher authenticated check behavior for TLS 1.2.
Call-outs:
N/A
Testing:
New unit test that allows all possible sigalgs, with the cipher authentication suite being the only restriction.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.