-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Finished-based APIs for TLS 1.3 #1952
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
==========================================
- Coverage 78.77% 78.76% -0.02%
==========================================
Files 590 590
Lines 101482 101506 +24
Branches 14396 14401 +5
==========================================
+ Hits 79945 79950 +5
- Misses 20902 20920 +18
- Partials 635 636 +1 ☔ View full report in Codecov by Sentry. |
samuel40791765
force-pushed
the
ssl-finished-tls13
branch
2 times, most recently
from
October 28, 2024 19:29
d96578a
to
f7d267e
Compare
smittals2
reviewed
Oct 29, 2024
smittals2
reviewed
Oct 29, 2024
smittals2
reviewed
Oct 29, 2024
samuel40791765
force-pushed
the
ssl-finished-tls13
branch
from
November 6, 2024 19:24
9fe8959
to
4428704
Compare
smittals2
previously approved these changes
Nov 6, 2024
smittals2
approved these changes
Nov 7, 2024
skmcgrail
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses
CryptoAlg-2699
Description of changes:
Another Ruby 3.1 test is depending on certain SSL APIs to retain information when using TLS1.3. This time it's the
SSL_get(_peer)_finished
APIs that are involved. OpenSSL treats the fields identically in 1.2 and 1.3 and uses the same API to update both state machines.We already have our own individual
ssl_get/send_finished
for TLS 1.2 andtls13_add/process_finished
for TLS 1.3. I've added the field updates within the corresponding TLS 1.3 functions so that these return the correct value within a 1.3 setting.Call-outs:
The field buffer for
previous_server_finished
andprevious_client_finished
has to grow past 12 since it's also used for1.3 now. This breaks the original SSL Transfer assumption and we'll have
to bump the version while adding corresponding logic to account for the
updated size. I've regenerated the SSL Transfer bytes for the round trip
tests and also added a test for that as well. We're not bumping the
version number here since it's a pretty minuscule change. This doesn't
break compatibility with us parsing older versions of AWS-LC SSL
Transfers, but older versions of AWS-LC won't be able to parse the new
version.
Testing:
WIP
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.