Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PKCS7_dataInit and PKCS7_dataFinal #1816

Merged
merged 9 commits into from
Nov 18, 2024
Merged

Implement PKCS7_dataInit and PKCS7_dataFinal #1816

merged 9 commits into from
Nov 18, 2024
+892 −17

Commits on Nov 11, 2024

  1. Import code and tests from pkcs7-ruby branch

    @WillChilds-Klein
    WillChilds-Klein committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    9d0aea3 View commit details
    Browse the repository at this point in the history

  2. Down to 1 memory leak

    @WillChilds-Klein
    WillChilds-Klein committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    5e8e80d View commit details
    Browse the repository at this point in the history

  3. Fix remaining memory leaks

    @WillChilds-Klein
    WillChilds-Klein committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e2811f4 View commit details
    Browse the repository at this point in the history

  4. Convert macros to concrete functions

    @WillChilds-Klein
    WillChilds-Klein committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    bafb345 View commit details
    Browse the repository at this point in the history

  5. Clean up code style, formatting, etc.

    @WillChilds-Klein
    WillChilds-Klein committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    02f113e View commit details
    Browse the repository at this point in the history

  6. Add doc comments to pkcs7.h

    @WillChilds-Klein
    WillChilds-Klein committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    aa9a47c View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. PR feedback

    @WillChilds-Klein
    WillChilds-Klein committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    82a0094 View commit details
    Browse the repository at this point in the history

  2. Next round of PR comments

    @WillChilds-Klein
    WillChilds-Klein committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c1d46a8 View commit details
    Browse the repository at this point in the history

  3. Some compilers didnt like the inline declaration?

    @WillChilds-Klein
    WillChilds-Klein committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    40696f9 View commit details
    Browse the repository at this point in the history