Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OPENSSL_NO_TLS_PHA with SSL_VERIFY_POST_HANDSHAKE #1668

Merged

Conversation

WillChilds-Klein
Copy link
Contributor

Notes

PR #1526 introduced the OPENSSL_NO_TLS_PHA directive mostly for the purposes of AWS-LC's compatibility with CPython, but in cpython PR #117785 @encukou points out that detecting the absence of OpenSSL's own SSL_VERIFY_POST_HANDSHAKE directive is sufficient. This change removes AWS-LC's OPENSSL_NO_TLS_PHA directive in favor of detecting absence of SSL_VERIFY_POST_HANDSHAKE.

Testing

  • existing CI integration tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.22%. Comparing base (b2bbd9c) to head (2fbd20b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1668   +/-   ##
=======================================
  Coverage   78.22%   78.22%           
=======================================
  Files         566      566           
  Lines       95193    95193           
  Branches    13665    13663    -2     
=======================================
+ Hits        74465    74466    +1     
  Misses      20133    20133           
+ Partials      595      594    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review June 26, 2024 14:31
@WillChilds-Klein WillChilds-Klein requested a review from a team as a code owner June 26, 2024 14:31
@WillChilds-Klein WillChilds-Klein merged commit cea04a6 into aws:main Jun 26, 2024
96 of 99 checks passed
@WillChilds-Klein WillChilds-Klein deleted the remove-OPENSSL_NO_TLS_PHA branch June 26, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants