-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenVPN error codes, SSL_get_peer_signature_* funcs, and first patch file #1584
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
- Coverage 78.16% 78.15% -0.01%
==========================================
Files 562 562
Lines 94683 94710 +27
Branches 13575 13579 +4
==========================================
+ Hits 74008 74022 +14
- Misses 20082 20093 +11
- Partials 593 595 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some style nits to fix.
Issues
CryptoAlg-2477
CryptoAlg-2478
Description of changes:
Call-outs:
The patch file is temporary and will likely change with future PRs
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.