Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i686-pc-windows-gnu external bindgen #621

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Dec 5, 2024

Issues:

Addresses #620

Description of changes:

  • Fix external bindgen for i686-pc-windows-gnu
  • Add/Fix CI tests for various Windows targets

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (c358484) to head (c034102).
Report is 127 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
- Coverage   95.80%   92.80%   -3.00%     
==========================================
  Files          61       67       +6     
  Lines        8143     9858    +1715     
  Branches        0     9858    +9858     
==========================================
+ Hits         7801     9149    +1348     
- Misses        342      426      +84     
- Partials        0      283     +283     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the fix-i686-windows-bindgen branch from 1cada38 to 660a7c1 Compare December 5, 2024 15:08
@justsmth justsmth marked this pull request as ready for review December 5, 2024 16:18
@justsmth justsmth requested a review from a team as a code owner December 5, 2024 16:18
@justsmth justsmth requested a review from skmcgrail December 5, 2024 17:53
@justsmth justsmth changed the title Fix i686-pc-windows-gnu exernal bindgen Fix i686-pc-windows-gnu external bindgen Dec 5, 2024
@justsmth justsmth merged commit a7a70cb into aws:main Dec 6, 2024
260 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants