Proposal - Add Async PreInitAsync to allow async operations such as configuration I #708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
A proposal to address #702
Description of changes:
PreInitAsync
toAbstractAspNetCoreFunction
that allows async operations to happen, such as loading configuration from secrets manager, before the webhost is initialized. (I'm not too fond of the name. I'd prefer justInitAsync()
and renameInit()
toInitWebHost()
but that would be a breaking change...)StartupMode
is setFirstRequest
which in an asynchronous call stack. It is not possible to call it whenStartupMode
is set toConstructor
as invoking async methods in a constructor is an anti-pattern. (If there is no specific advantage to usingConstructor
startup mode, could it be argued to remove it? 🤷 )PreInitAsync()
is called. I also noticed there was no tests / test coverage forStartMode.FirstRequest
; this test now covers it.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.