add packaging of runtime #1897
Draft
add packaging of runtime #1897
+66
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcbeattyAWS
commented
Dec 5, 2024
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Include="$(OutputPath)Amazon.Lambda.RuntimeSupport.dll" Pack="true" PackagePath="content" Visible="false" /> |
There was a problem hiding this comment.
wasnt sure if this needed to be content or lib folder. was seeing this warning when doing pack command
The assembly 'content\Amazon.Lambda.RuntimeSupport.dll' is not inside the 'lib' folder and hence it won't be added as a reference when the package is installed into a project. Move it into the 'lib' folder if it needs to be referenced.
but in our case in we are referencing the dll as part of a command line argument in the aspire proof of concept , so not sure if it really matters
gcbeattyAWS
commented
Dec 5, 2024
| public class PackagingTests | ||
| { | ||
| [Fact] | ||
| public void VerifyPackageContentsHasRuntimeSupport() |
There was a problem hiding this comment.
added this test case but wasnt sure it was overkill or not
gcbeattyAWS
commented
Dec 5, 2024
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Include="$(OutputPath)Amazon.Lambda.RuntimeSupport.dll" Pack="true" PackagePath="content" Visible="false" /> |
There was a problem hiding this comment.
i still need to test end to end with aspire poc if any more (lambda core dlls) are needed or anything else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.