-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update lambda container images and test tool to .NET9 #1865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't drop .NET 6 yet till Lambda actually makes the .NET 6 managed runtime deprecated. Any by deprecated I mean stop allowing customers to create and update .NET 6 Lambda functions. Although there might not be anymore Microsoft patches we might have to patch our code like Amazon.Lambda.RuntimeSupport.
e4c89a2
to
1f63449
Compare
Reverted .NET6 changes |
code seems fine to me. is there anyway to test the changes before merging? or how were the changes tested? |
I agree with @gcbeattyAWS that a note in the PR description on how this was tested would be good. |
I tested the changes by deploying the pipelines to my account and verified that they ran to completion. I also added a note in the description that explains this. |
45d4c54
to
90084f8
Compare
90084f8
to
bf18097
Compare
Issue #, if available:
DOTNET-7790
Description of changes:
Note: The pipelines were deployed to my dev account and ran to completion.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.