Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update lambda container images and test tool to .NET9 #1865

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

philasmar
Copy link
Contributor

@philasmar philasmar commented Nov 8, 2024

Issue #, if available:
DOTNET-7790

Description of changes:

  • Added .NET9 target for Lambda Container Images and Test Tool
  • Dropped .NET7 since it is already out of support
  • Updated the CodePipeline to V2 and dropped CodeCommit support
  • Updated build script in Lambda Container Images pipeline to create an ECR registry if ones doesn't exist.

Note: The pipelines were deployed to my dev account and ran to completion.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@philasmar philasmar requested review from normj and 96malhar November 8, 2024 16:13
Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't drop .NET 6 yet till Lambda actually makes the .NET 6 managed runtime deprecated. Any by deprecated I mean stop allowing customers to create and update .NET 6 Lambda functions. Although there might not be anymore Microsoft patches we might have to patch our code like Amazon.Lambda.RuntimeSupport.

@philasmar
Copy link
Contributor Author

We can't drop .NET 6 yet till Lambda actually makes the .NET 6 managed runtime deprecated. Any by deprecated I mean stop allowing customers to create and update .NET 6 Lambda functions. Although there might not be anymore Microsoft patches we might have to patch our code like Amazon.Lambda.RuntimeSupport.

Reverted .NET6 changes

@gcbeattyAWS
Copy link

code seems fine to me. is there anyway to test the changes before merging? or how were the changes tested?

@normj
Copy link
Member

normj commented Nov 8, 2024

code seems fine to me. is there anyway to test the changes before merging? or how were the changes tested?

I agree with @gcbeattyAWS that a note in the PR description on how this was tested would be good.

@philasmar
Copy link
Contributor Author

code seems fine to me. is there anyway to test the changes before merging? or how were the changes tested?

I tested the changes by deploying the pipelines to my account and verified that they ran to completion. I also added a note in the description that explains this.

@philasmar philasmar merged commit 4c71ea2 into dev Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants