Add support for .NET 8 to Lambda Annotations

[ashovlin]

Issue #, if available: DOTNET-7321

Description of changes: This adds support for the upcoming .NET 8 managed runtime to Lambda Annotations.

• Previously: Since dotnet6 was the only managed runtime when annotations launched we hardcoded dotnet6 when generating the CloudFormation for a zip package type
• Now: We support dotnet8 in either the LambdaGlobalProperties attribute or by detecting it in the user's csproj.

On Detection

1. From internal discussions, we didn't want to simply parse the .csproj's XML for <TargetFramework> since that leaves us susceptible to issues like Directory.build.props heirarchy is not respected aws-extensions-for-dotnet-cli#211
2. I could not find a way to detect the TFM from the context available to the source generator (GeneratorExecutionContext)
   • https://stackoverflow.com/questions/59843783/determine-target-framework-inside-a-visual-studio-code-analyzer-roslyn
3. I explored using Micorosft.Build and Microsoft.Build.Locator, but those don't target .NET Standard so I don't think we can use them from a source generator.
4. Norm suggested the new dotnet msbuild -getProperty which is available with 17.8 (8.0.1) Edit: see Add support for .NET 8 to Lambda Annotations #1658
   • https://learn.microsoft.com/en-us/visualstudio/msbuild/evaluate-items-and-properties?view=vs-2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ashovlin]

fyi: I was only adding line 14, my VS sorted the list.

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[ashovlin]

Unrelated to this change, just moving the errors we added in 1.1.0 to the shipped file.

[philasmar]

Should we just increment the version to the one we intend to release this PR in? (and do it for all the other snaphsot files)

[ashovlin]

Given the churn we've had with .NET 8, I didn't want to tie this to a version yet so would just do the separate versioning PR.

[normj]

Can you update the following comment block to include dotnet8.

https://github.com/aws/aws-lambda-dotnet/blob/master/Libraries/src/Amazon.Lambda.Annotations/LambdaGlobalPropertiesAttribute.cs#L22

[ashovlin]

Summarizing today's commits from internal discussion: I had seen prior art for the following:

context.AnalyzerConfigOptions.GlobalOptions.TryGetValue("build_property.TargetFramework", out var targetFramework);

But when I initially tried it out, targetFramework was null so I gave up. However I was testing this through our CSharpSourceGeneratorTest which wasn't setting the TFM appropriately. When manually testing the full package in a test project targetFramework was set appropriately.

e6ec280 now pivots to this approach and removes the dotnet msbuild -getProperty which should be more performant.

[ashovlin]

Can you update the following comment block to include dotnet8.

https://github.com/aws/aws-lambda-dotnet/blob/master/Libraries/src/Amazon.Lambda.Annotations/LambdaGlobalPropertiesAttribute.cs#L22

Fixed in a1aac5a, thanks.