Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #1638

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Fix typo #1638

merged 4 commits into from
Dec 15, 2023

Conversation

t0mll
Copy link
Contributor

@t0mll t0mll commented Dec 11, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dscpinheiro dscpinheiro changed the base branch from master to dev December 12, 2023 18:25
Copy link
Member

@ashovlin ashovlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the target to dev, which is pulling along some changes from master that weren't already there. But that's okay, we try to keep them in sync anyway. Changes in this PR's commit look good, thanks for the contribution!

@ashovlin ashovlin merged commit 397df02 into aws:dev Dec 15, 2023
3 of 4 checks passed
ashovlin added a commit that referenced this pull request Dec 15, 2023
ashovlin added a commit that referenced this pull request Dec 15, 2023
* Update Amazon.Lambda.Templates version for release
* test: Fix test that was asserting against error message after #1638 fixed typos.
@ashovlin
Copy link
Member

We've merged both of the typo-fix PRs to master, but haven't yet put out a new Amazon.Lambda.Annotations package yet. My inclination was to wait for a more functional fix or feature before publishing a new package.

@t0mll t0mll deleted the diagnostic-descriptor-cleanup branch December 18, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants