Add smoke test to Lambda OCI images for TZData being available. #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boblodgett
approved these changes
Dec 8, 2023
normj
commented
Dec 8, 2023
| @@ -170,6 +171,7 @@ private async Task CreateFunctionAsync() | |||
| MemorySize = 512, | |||
| Role = _executionRoleArn, | |||
| PackageType = PackageType.Image, | |||
| Timeout = 30, | |||
There was a problem hiding this comment.
I added the timeout because the default value is 3 seconds and apparently listing all of the timezones at least for the first time can take longer then 3 seconds.
ashovlin
approved these changes
Dec 8, 2023
philasmar
approved these changes
Dec 8, 2023
philasmar
reviewed
Dec 8, 2023
normj
force-pushed
the
normj/add-tzdata-test
branch
from
c445154 to
f9a06d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add a smoke test to our Lambda OCI publish process that confirms the availability of TZData. The
provided.al2023did not initially have this as reported by issue #1620 and has sense been added.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.