Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blueprints for provided.al2023 and dependency updates #1606

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

normj
Copy link
Member

@normj normj commented Nov 10, 2023

Description of changes:

  • Updated the custom runtime functions to use .NET 8 and provided.al2023 runtime.
  • Ran build tool to update all of the AWS packages in the blueprints
  • Some minor clean to README files

Test by manually creating the custom runtime templates in Visual Studio and verified they built, tests passed and project could deployed. Also ran the build target to automatically build all templates.

*Note
The provided.al2 has an old version of libicu that didn't work for ARM versions of .NET so we included the Microsoft.ICU.ICU4C.Runtime package for ARM publishing to include libicu with the deployment bundle. The provided.al2023 does not have libicu installed at all. So now we always include the Microsoft.ICU.ICU4C.Runtime package regardless of architecture.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* CustomRuntime blueprints use provided.al2023 and .NET 8
* Update all AWS package references.
"description": "Use Lambda Custom Runtime feature to build Lambda functions using .NET 7.",
"sort-order": 400,
"description": "Use Lambda Custom Runtime feature to build Lambda functions using .NET 8.",
"sort-order": 125,
Copy link
Member Author

@normj normj Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the sort order to make the custom runtime blueprints more prominent now that we are targeting .NET 8. This is used in the Visual Studio wizard in how it sorts all of the blueprints in the wizard.

@@ -51,11 +51,6 @@ Deploy function to AWS Lambda
dotnet lambda deploy-function
```

## Arm64
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not needed because anymore. We are targeting .NET 8 and not 7 anymore. And we are using using provided.al2023 not provided.al2.

Actually this comment was stale because in a later patch of .NET 7 Microsoft lowered the requirements of GLIBC to allow ARM to work on AL2.

@@ -14,7 +14,7 @@ namespace Packager
public class UpdatePackageReferenceVersions
{
const string MicrosoftAspNetCoreAppVersion = "2.1.4";
const string AWSSDK_VERSION_MANIFEST = "https://raw.githubusercontent.com/aws/aws-sdk-net/master/generator/ServiceModels/_sdk-versions.json";
const string AWSSDK_VERSION_MANIFEST = "https://raw.githubusercontent.com/aws/aws-sdk-net/main/generator/ServiceModels/_sdk-versions.json";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of the build tooling that looks at the SDK's version file to see what the current versions are to update in the template. Since the SDK no uses main I switched this to current.

@normj normj merged commit b63d368 into dev Nov 10, 2023
2 of 3 checks passed
@normj normj deleted the normj/update-blueprints-al2023 branch November 10, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants